linux-kernel - Re: [PATCH] x86[-64] PCI domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060930104248.GR22787@rhun.haifa.ibm.com>
Date:	Sat, 30 Sep 2006 13:42:48 +0300
From:	Muli Ben-Yehuda <muli@...ibm.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Andrew Morton <akpm@...l.org>, Greg KH <greg@...ah.com>,
	Jim Paradis <jparadis@...hat.com>, Andi Kleen <ak@...e.de>,
	LKML <linux-kernel@...r.kernel.org>, jdmason@...zu.us
Subject: Re: [PATCH] x86[-64] PCI domain support

On Sat, Sep 30, 2006 at 06:03:11AM -0400, Jeff Garzik wrote:

> Would you also make sure that Andrew has the necessary bits to keep 
> Calgary going under PCI domains?  If it's a patch that sits on top of 
> linux-2.6.git + my patch, I can merge it into misc-2.6.git#pciseg (which 
> automatically goes into -mm).  Otherwise, make sure -mm has the stack of 
> patches necessary.

The patch I posted earlier is all that's needed, if you could merge it
into #pciseg that would be fine. I'm pondering making one small
change though: in your pci domains patch, you have this snippet:

+#ifdef CONFIG_PCI_DOMAINS
+static inline int pci_domain_nr(struct pci_bus *bus)
+{
+	struct pci_sysdata *sd = bus->sysdata;
+	return sd->domain;
+}
+
+static inline int pci_proc_domain(struct pci_bus *bus)
+{
+	return pci_domain_nr(bus);
+}
+#endif /* CONFIG_PCI_DOMAINS */

So pci_domain_nr and pci_proc_domain are only available if
CONFIG_PCI_DOMAINS is defined. I followed suit and make pci_iommu only
available if CONFIG_CALGARY_IOMMU is defined, but perhaps it would be
better to make it unconditional, since ->sysdata will always be
available anyway. Was there a specific reason why pci_domain_nr is
only available if CONFIG_PCI_DOMAINS?

Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/