linux-kernel - Re: [PATCH -mm 1/3] swsusp: Add ioctl for swap files support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Sep 2006 21:58:02 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Pavel Machek <pavel@....cz>, Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 1/3] swsusp: Add ioctl for swap files support

On Saturday, 30 September 2006 16:15, Arnd Bergmann wrote:
> Am Friday 29 September 2006 01:35 schrieb Rafael J. Wysocki:
> > @@ -119,7 +119,18 @@ extern int snapshot_image_loaded(struct
> >  #define SNAPSHOT_SET_SWAP_FILE         _IOW(SNAPSHOT_IOC_MAGIC, 10,
> > unsigned int) #define
> > SNAPSHOT_S2RAM                 _IO(SNAPSHOT_IOC_MAGIC, 11) #define
> > SNAPSHOT_PMOPS                 _IOW(SNAPSHOT_IOC_MAGIC, 12, unsigned int)
> > -#define SNAPSHOT_IOC_MAXNR     12
> > +#define SNAPSHOT_SET_SWAP_AREA         _IOW(SNAPSHOT_IOC_MAGIC, 13, void *) 
> > +#define SNAPSHOT_IOC_MAXNR     13
> 
> Your definition looks wrong, '_IOW(SNAPSHOT_IOC_MAGIC, 13, void *)' means
> your ioctl passes a pointer to a 'void *'.
> 
> You probably mean 
> 
> #define SNAPSHOT_SET_SWAP_AREA _IOW(SNAPSHOT_IOC_MAGIC, 13, \
> 						struct resume_swap_area)

No.  I mean the ioctl passes a pointer, the size of which is sizeof(void *).

Greetings,
Rafael


-- 
You never change things by fighting the existing reality.
		R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/