linux-kernel - [PATCH] Char: serial167, remove useless tty check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun,  1 Oct 2006 01:23:59 +0200 (CEST)
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	<bentson@...eg.seaslug.org>
Subject: [PATCH] Char: serial167, remove useless tty check

serial167, remove useless tty check

tty is dereferenced before it is checked to be nonNULL. Remove such check.

Signed-off-by: Jiri Slaby <jirislaby@...il.com>

---
commit 00bed6b2fb10dd07cdde1f6ebe8066058b748ce1
tree b69d8cc230471d1e5dfa09d273960997deb42eba
parent 810378cbe277c73f99219e343f54e782459b6b61
author Jiri Slaby <jirislaby@...il.com> Sun, 01 Oct 2006 01:12:34 +0200
committer Jiri Slaby <xslaby@...moi.localdomain> Sun, 01 Oct 2006 01:12:34 +0200

 drivers/char/serial167.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c
index 48dae5d..f4809c8 100644
--- a/drivers/char/serial167.c
+++ b/drivers/char/serial167.c
@@ -1121,7 +1121,7 @@ #endif
     if (serial_paranoia_check(info, tty->name, "cy_put_char"))
 	return;
 
-    if (!tty || !info->xmit_buf)
+    if (!info->xmit_buf)
 	return;
 
     local_irq_save(flags);
@@ -1187,7 +1187,7 @@ #endif
 	return 0;
     }
 	
-    if (!tty || !info->xmit_buf){
+    if (!info->xmit_buf){
         return 0;
     }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/