linux-kernel - Re: [PATCH] I2O: mark i2o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <451FF0B1.9040706@shadowconnect.com>
Date:	Sun, 01 Oct 2006 18:45:37 +0200
From:	Markus Lidel <Markus.Lidel@...dowconnect.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Jeff Garzik <jeff@...zik.org>, Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] I2O: mark i2o_config broken on 64-bit

Hello,

Roland Dreier wrote:
>  > -			//TODO 64bit fix
>  > +			//FIXME: broken on 64-bit
>  >  			sg[i].addr_bus = (u32) p->phys;
> This looks worse than just broken on 64 bit.  I didn't even attempt to
> understand what's going on here, but would this even work on 32 bit
> systems that have physical addresses above 4 gigs (eg i386 with PAE)?

It's a kind of user-space driver :-D This part of the driver just send 
the data generated in the user-space program 1:1 to the controller. It 
works on 64-bit, but i doubt it works with 64-bit DMA addresses. This 
part of the code was copied from "drivers/scsi/dpt_i2o.c". I already 
tried to replace it with an IMHO nicer sysfs solution, but because this 
also required an "workaround" it was dropped again.



Best regards,


Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)

Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany

Phone:  +49 82 82/99 51-0
Fax:    +49 82 82/99 51-11

E-Mail: Markus.Lidel@...dowconnect.com
URL:    http://www.shadowconnect.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/