linux-kernel - Re: [patch 2.6.18-git] RTC class uses subsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061001022022.d7f86b39.akpm@osdl.org>
Date:	Sun, 1 Oct 2006 02:20:22 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Olaf Hering <olaf@...fle.de>
Cc:	David Brownell <david-b@...bell.net>,
	Alessandro Zummo <alessandro.zummo@...ertech.it>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2.6.18-git] RTC class uses subsys_init

On Sun, 1 Oct 2006 11:07:17 +0200
Olaf Hering <olaf@...fle.de> wrote:

> On Thu, Sep 28, David Brownell wrote:
> 
> 
> > +++ linux/drivers/rtc/rtc-sysfs.c	2006-07-30 16:15:50.000000000 -0700
> > @@ -116,7 +116,7 @@
> >  	class_interface_unregister(&rtc_sysfs_interface);
> >  }
> >  
> > -module_init(rtc_sysfs_init);
> > +subsys_init(rtc_sysfs_init);
> >  module_exit(rtc_sysfs_exit);
> 
> subsys_init is not defined, but the change is in Linus tree now.

doh.  But it still compiled.

drivers/rtc/rtc-sysfs.c:119: warning: data definition has no type or storage class
drivers/rtc/rtc-sysfs.c:119: warning: type defaults to 'int' in declaration of 'subsys_init'
drivers/rtc/rtc-sysfs.c:119: warning: parameter names (without types) in function declaration
drivers/rtc/rtc-sysfs.c:110: warning: 'rtc_sysfs_init' defined but not used

I'll fix it up.

(Wonders how it passed runtime testing..)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/