linux-kernel - x86 BUG bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <451FA997.9050000@garzik.org>
Date:	Sun, 01 Oct 2006 07:42:15 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andi Kleen <ak@...e.de>
CC:	Andrew Morton <akpm@...l.org>
Subject: x86 BUG bug

I have a couple ATA drivers that spit out "foo might be used 
uninitialized" warnings.  Rather than the usual gcc nonsense, it turns 
out that the code follows this pattern:

	type_t foo;

	if (condition 1)
		foo = x;
	else if (condition 2)
		foo = y;
	else
		BUG();

It doesn't warn on other platforms, so I dug into the BUG() code on x86, 
and discovered that it is missing the 'noreturn' attribute found in 
other BUG() definitions.

Being rusty on the gcc asm syntax -- does an inline asm statement permit 
'noreturn'? -- I figured it would be best just to report this, rather 
than create a patch myself.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/