linux-kernel - Re: [PATCH] drivers/char/ip2: kill unused code, label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1159750627.24836.1.camel@canyon.wittsend.com>
Date:	Sun, 01 Oct 2006 20:57:07 -0400
From:	"Michael H. Warfield" <mhw@...tsEnd.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	mhw@...tsEnd.com, Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/char/ip2: kill unused code, label

On Sun, 2006-10-01 at 11:37 -0400, Jeff Garzik wrote:
> Kill warning:

> drivers/char/ip2/ip2main.c: In function ‘ip2_loadmain’:
> drivers/char/ip2/ip2main.c:782: warning: label ‘out_class’ defined but not used

> This driver's initialization (and cleanup of errors during init) is
> extremely convoluted, and could stand to be transformed into the
> standard unwinding-goto style of error cleanup.

> Signed-off-by: Jeff Garzik <jeff@...zik.org>

	Looks good to me.  I'll look into the unwinding suggestion.

	Signed-off-by: Michael H. Warfield <mhw@...tsend.com>

> diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c
> index 331f447..bcf6573 100644
> --- a/drivers/char/ip2/ip2main.c
> +++ b/drivers/char/ip2/ip2main.c
> @@ -779,8 +779,6 @@ retry:
>  	ip2trace (ITRC_NO_PORT, ITRC_INIT, ITRC_RETURN, 0 );
>  	goto out;
>  
> -out_class:
> -	class_destroy(ip2_class);
>  out_chrdev:
>  	unregister_chrdev(IP2_IPL_MAJOR, "ip2");
>  out:
-- 
Michael H. Warfield (AI4NB) | (770) 985-6132 |  mhw@...tsEnd.com
   /\/\|=mhw=|\/\/          | (678) 463-0932 |  http://www.wittsend.com/mhw/
   NIC whois: MHW9          | An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471        | possible worlds.  A pessimist is sure of it!


Download attachment "signature.asc" of type "application/pgp-signature" (308 bytes)