linux-kernel - Re: linux/compat.h includes asm/signal.h causing problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061002135036.7bd1f76b.akpm@osdl.org>
Date:	Mon, 2 Oct 2006 13:50:36 -0700
From:	Andrew Morton <akpm@...l.org>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
	Jens Axboe <axboe@...e.de>
Subject: Re: linux/compat.h includes asm/signal.h causing problems

On Mon, 02 Oct 2006 13:14:14 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> 
> On some platforms, including sparc64, asm/signal.h needs
> compat_sigset_t, but this is defined in linux/compat.h
> after asm/signal.h is included.
> 
> Andrew, aren't you doing sparc64 cross builds these days? :-)
> 
> This came from 3f2e05e90e0846c42626e3d272454f26be34a1bc
> 
>     [PATCH] BLOCK: Revert patch to hack around undeclared sigset_t in linux/compat.h
>     
>     Revert Andrew Morton's patch to temporarily hack around the lack of a
>     declaration of sigset_t in linux/compat.h to make the block-disablement
>     patches build on IA64.  This got accidentally pushed to Linus and should
>     be fixed in a different manner.
>     
>     Also make linux/compat.h #include asm/signal.h to gain a definition of
>     sigset_t so that it can externally declare sigset_from_compat().
>     
>     This has been compile-tested for i386, x86_64, ia64, mips, mips64, frv, ppc and
>     ppc64 and run-tested on frv.
>     
>     Signed-off-by: David Howells <dhowells@...hat.com>
>     Signed-off-by: Linus Torvalds <torvalds@...l.org>
> 
> It figures that one of the platforms it wasn't compile tested on is
> the one that breaks :-)

not me, boss - I told 'em that using sigset_t in compat.h was a minefield. 
sparc64 built OK with my hack-shouldnt-be-merged patch applied, which is
how it was tested in -mm.

I don't know what a good fix is, really.  I guess one could put the
declaration of sigset_from_compat() into its own header file and include
that header from the right places.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/