linux-kernel - [patch] dynticks: core, NMI watchdog fix, #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061002085453.GA6403@elte.hu>
Date:	Mon, 2 Oct 2006 10:54:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...l.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, Jim Gettys <jg@...top.org>,
	John Stultz <johnstul@...ibm.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Dave Jones <davej@...hat.com>
Subject: [patch] dynticks: core, NMI watchdog fix, #2


Andrew, there's one more fallout of the dyntick queue: the fix below 
goes after (or into) dynticks-core-nmi-watchdog-fix.patch. The bug only 
affected NO_HZ kernels.

	Ingo

----------------->
Subject: dynticks: core, NMI watchdog fix, #2
From: Ingo Molnar <mingo@...e.hu>

a partial fix of the NMI watchdog bug sneaked into yesterday night's
queue - this patch removes that extra in_interrupt() condition.

(One effect of this bug is a 'slow' serial console on NO_HZ, because we 
never update jiffies and the serial console's timeouts get confused by 
it.)

Signed-off-by: Ingo Molnar <mingo@...e.hu>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 kernel/softirq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/kernel/softirq.c
===================================================================
--- linux.orig/kernel/softirq.c
+++ linux/kernel/softirq.c
@@ -280,7 +280,7 @@ void irq_enter(void)
 {
 	__irq_enter();
 #ifdef CONFIG_NO_HZ
-	if (idle_cpu(smp_processor_id()) && !in_interrupt())
+	if (idle_cpu(smp_processor_id()))
 		hrtimer_update_jiffies();
 #endif
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/