linux-kernel - Re: [PATCH 1/6] Generic implemenatation of BUG.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061003103740.GB73786@muc.de>
Date:	Tue, 3 Oct 2006 12:37:40 +0200
From:	Andi Kleen <ak@....de>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Hugh Dickens <hugh@...itas.com>,
	Michael Ellerman <michael@...erman.id.au>,
	Paul Mackerras <paulus@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH 1/6] Generic implemenatation of BUG.

> Because powerpc also records the function name, I added this to i386 and
> x86-64 for consistency.  Strictly speaking the function name is redundant with
> kallsyms, so perhaps it can be dropped from powerpc.

It would be good to change it to use kallsyms() then.

>  
>  #ifdef CONFIG_BUG
> +
> +#ifdef CONFIG_GENERIC_BUG
> +struct bug_entry {
> +	unsigned long	bug_addr;
> +#ifdef CONFIG_DEBUG_BUGVERBOSE
> +	const char	*file;
> +	unsigned short	line;
> +#endif
> +	unsigned short	flags;

Can't you put the flags into the high bits of the line? I don't think
we have any 64kLOC files.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/