[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20061003150723.GG7716@cosmic.amd.com>
Date: Tue, 3 Oct 2006 09:07:23 -0600
From: "Jordan Crouse" <jordan.crouse@....com>
To: linux-fbdev-devel@...ts.sourceforge.net
cc: "Linux Kernel Development" <linux-kernel@...r.kernel.org>,
devel@...top.org
Subject: Re: video: Get the default mode from the right database
On 03/10/06 09:04 +0200, Geert Uytterhoeven wrote:
> > if (!default_mode)
> > - default_mode = &modedb[DEFAULT_MODEDB_INDEX];
> > + default_mode = &db[DEFAULT_MODEDB_INDEX];
> > if (!default_bpp)
> > default_bpp = 8;
>
> Although currently DEFAULT_MODEDB_INDEX is defined to be 0, perhaps we need a
> more rigorous check now it may apply to the custom video mode database?
> Probably you always want the first mode of your custom video mode database to
> be the default?
Indeed. I'm not sure how many people out there actually change
DEFAULT_MODEDB_INDEX to be non zero, but can't think of a reason why the
default shouldn't just always use the first index in the database.
At least, thats the way I thought fb_find_mode() worked before I looked into
the internals. Still, there might be some people attached to
DEFAULT_MODEDB_INDEX, so I've attached a new patch that should make everybody
happy.
Jordan
--
Jordan Crouse
Senior Linux Engineer
Advanced Micro Devices, Inc.
<www.amd.com/embeddedprocessors>
View attachment "modedb-fix.patch" of type "text/plain" (816 bytes)
Powered by blists - more mailing lists