linux-kernel - Re: [PATCH] IPC namespace core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Oct 2006 10:02:54 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Kirill Korotaev <dev@...nvz.org>,
	Pavel Emelianov <xemul@...nvz.org>,
	Cedric Le Goater <clg@...ibm.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] IPC namespace core

On Mon, 2006-10-02 at 16:01 +0000, Linux Kernel Mailing List wrote:
> commit 25b21cb2f6d69b0475b134e0a3e8e269137270fa
> tree cd9c3966408c0ca5903249437c35ff35961de544
> parent c0b2fc316599d6cd875b6b8cafa67f03b9512b4d
> author Kirill Korotaev <dev@...nvz.org> 1159780699 -0700
> committer Linus Torvalds <torvalds@...osdl.org> 1159801042 -0700
> 
> [PATCH] IPC namespace core
> 
> This patch set allows to unshare IPCs and have a private set of IPC objects
> (sem, shm, msg) inside namespace.  Basically, it is another building block of
> containers functionality.
> 
> This patch implements core IPC namespace changes:
> - ipc_namespace structure
> - new config option CONFIG_IPC_NS
> - adds CLONE_NEWIPC flag
> - unshare support
> 
> [clg@...ibm.com: small fix for unshare of ipc namespace]
> [akpm@...l.org: build fix]
> Signed-off-by: Pavel Emelianov <xemul@...nvz.org>
> Signed-off-by: Kirill Korotaev <dev@...nvz.org>
> Signed-off-by: Cedric Le Goater <clg@...ibm.com>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Signed-off-by: Andrew Morton <akpm@...l.org>
> Signed-off-by: Linus Torvalds <torvalds@...l.org>

> --- a/include/linux/ipc.h
> +++ b/include/linux/ipc.h
> @@ -2,6 +2,7 @@ #ifndef _LINUX_IPC_H
>  #define _LINUX_IPC_H
>  
>  #include <linux/types.h>
> +#include <linux/kref.h>
>  
>  #define IPC_PRIVATE ((__kernel_key_t) 0)  
>  

You need to move the #include down the file by about 50 lines so it
lands inside the existing #ifdef __KERNEL__.

All those signed-off-bys and _none_ of you managed to notice that
<linux/kref.h> doesn't exist in the headers we export to userspace,
despite the fact that just running 'make headers_check' would have
shouted at you about it?

Bad hacker. No biscuit.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/