linux-kernel - Re: [RFC PATCH] move tg3 to pci_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061004090906.GA3158@slug>
Date:	Wed, 4 Oct 2006 09:09:06 +0000
From:	Frederik Deweerdt <deweerdt@...e.fr>
To:	David Miller <davem@...emloft.net>
Cc:	jeff@...zik.org, linux-kernel@...r.kernel.org, arjan@...radead.org,
	matthew@....cx, alan@...rguk.ukuu.org.uk, akpm@...l.org,
	rdunlap@...otime.net, gregkh@...e.de
Subject: Re: [RFC PATCH] move tg3 to pci_request_irq

On Tue, Oct 03, 2006 at 11:27:48PM -0700, David Miller wrote:
> From: Jeff Garzik <jeff@...zik.org>
> Date: Wed, 04 Oct 2006 01:38:31 -0400
> 
> > As for why the flag may be missing -- PCI MSI interrupts are never 
> > shared.  However, it won't _hurt_ anything to set the flag needlessly, 
> > AFAIK.
> 
> That's right.
Just to make sure I understood: does this means that the code at lines
296 and 297 in e1000_main.c can be safely removed?

 296 if (adapter->have_msi)
 297 	flags &= ~IRQF_SHARED;
 298 #endif
 299 if ((err = request_irq(adapter->pdev->irq, &e1000_intr, flags,
 300 	netdev->name, netdev)))
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/