linux-kernel - Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061004080637.0bd19042.pj@sgi.com>
Date:	Wed, 4 Oct 2006 08:06:37 -0700
From:	Paul Jackson <pj@....com>
To:	Joe Korty <joe.korty@...r.com>
Cc:	akpm@...l.org, reinette.chatre@...ux.intel.com,
	linux-kernel@...r.kernel.org, inaky@...ux.intel.com
Subject: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a
 user buffer

Joe wrote:
> I guess I am a sucker for no-transient-buffer (bufferless?)

Ah - that explains Joe's preference for putting the actual implementing
code in the user version - it gets to pull in the user string one
char at a time, avoiding a malloc'd buffer.

I tend to make more coding mistakes that way, so have gotten in the
habit of keeping my scanning code separate from any code required to
get a nice safe local copy of the input that is to be scanned.

I agree with Joe - either way can be made to work - author's
discretion.  Just be sure to impose that sanity limit.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/