linux-kernel - [Patch] Remove unnecessary check in fs/fat/inode.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Oct 2006 18:23:20 +0200
From:	Eric Sesterhenn <snakebyte@....de>
To:	linux-kernel@...r.kernel.org
Cc:	hirofumi@...l.parknet.co.jp
Subject: [Patch] Remove unnecessary check in fs/fat/inode.c

hi,

since all callers dereference sb, and this function
does so earlier too, we dont need the check.

Signed-off-by: Eric Sesterhenn <snakebyte@....de>

--- linux-2.6.18-git21/fs/fat/inode.c.orig	2006-10-04 18:21:03.000000000 +0200
+++ linux-2.6.18-git21/fs/fat/inode.c	2006-10-04 18:21:22.000000000 +0200
@@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block 
 		ret = writeback_inode(i1);
 	if (!ret && i2)
 		ret = writeback_inode(i2);
-	if (!ret && sb) {
+	if (!ret) {
 		struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
 		ret = filemap_flush(mapping);
 	}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/