linux-kernel - Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061004171436.GA25461@tsunami.ccur.com>
Date:	Wed, 4 Oct 2006 13:14:36 -0400
From:	Joe Korty <joe.korty@...r.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Reinette Chatre <reinette.chatre@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Inaky Perez-Gonzalez <inaky@...ux.intel.com>,
	Paul Jackson <pj@....com>
Subject: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer

On Wed, Oct 04, 2006 at 09:40:29AM -0700, Andrew Morton wrote:
> I think we can do a version which omits the kmalloc altogether:

> 			if (__get_user(c, ubuf++))
> 				return -EFAULT;
> 
> (Note the s/get_user/__get_user/)

Nice.  This eliminates the bulk of the get_user() overhead.  And
it can be merged into Inaky's enum solution too, for something
that is both simple and efficient.

Joe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/