linux-kernel - Re: [patch] call truncate_inode_pages in the DIO fallback to buffered I/O path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45240034.2040704@oracle.com>
Date:	Wed, 04 Oct 2006 11:40:52 -0700
From:	Zach Brown <zach.brown@...cle.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Jeff Moyer <jmoyer@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [patch] call truncate_inode_pages in the DIO fallback to buffered
 I/O path

> We have lots of nice new tools in-kernel which permit applications to
> manipulate and to invalidate pagecache.  Please, start using them rather
> than pushing bits of oracle into the core vfs ;)

And apps that were written before they were available? :)  We're OK with
their behaviour changing under newer kernels because they now have a
previous source of memory pressure that they didn't have before?

It seems a bit much to suggest that retaining the previous behaviour of
avoiding memory pressure by using the O_DIRECT API is somehow "pushing
bits of oracle into the core vfs" :).

Maybe that aspect of the API was unintentional, though.  That would be a
shame.  I suspect Oracle isn't alone in relying on it.

> Please, no truncate_inode_pages.  For this application, the far-safer
> invalidate_inode_pages() would suffice.

So now apps always have to pay the cost of looking up pages to
invalidate on the off chance that they wrote to a sparse region, based
on the current implementation detail that sparse regions fall back to
buffered?

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/