[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4524106C.8010807@garzik.org>
Date: Wed, 04 Oct 2006 15:50:04 -0400
From: Jeff Garzik <jeff@...zik.org>
To: Frederik Deweerdt <deweerdt@...e.fr>
CC: linux-kernel@...r.kernel.org, arjan@...radead.org, matthew@....cx,
alan@...rguk.ukuu.org.uk, akpm@...l.org, rdunlap@...otime.net,
gregkh@...e.de
Subject: Re: [RFC PATCH] add pci_{request,free}_irq take #3
Frederik Deweerdt wrote:
> --- 2.6.18-mm3.orig/include/linux/interrupt.h
> +++ 2.6.18-mm3/include/linux/interrupt.h
> @@ -75,6 +75,13 @@ struct irqaction {
> struct proc_dir_entry *dir;
> };
>
> +#ifndef ARCH_VALIDATE_IRQ
> +static inline int is_irq_valid(unsigned int irq)
> +{
> + return irq ? 1 : 0;
> +}
> +#endif /* ARCH_VALIDATE_IRQ */
I ACK everything except the above snippet. I just don't think it's
linux/interrupt.h material, sorry.
If a consensus of arch maintainers (i.e. not just willy) think it's
fine, then I'm overruled, otherwise...
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists