linux-kernel - [patch] x86, fix rwsem build bug on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061005082757.GA27120@elte.hu>
Date:	Thu, 5 Oct 2006 10:27:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Linus Torvalds <torvalds@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Klaus Knopper <knopper@...pper.net>, Andi Kleen <ak@...e.de>,
	Luca Tettamanti <kronos.it@...il.com>, gregkh@...e.de,
	linux-pci@...ey.karlin.mff.cuni.cz, discuss@...-64.org,
	Thierry Vignaud <tvignaud@...driva.com>, jgarzik@...ox.com,
	linux-ide@...r.kernel.org,
	"Michael S. Tsirkin" <mst@...lanox.co.il>, len.brown@...el.com,
	linux-acpi@...r.kernel.org, Olaf Hering <olaf@...fle.de>,
	Jens Axboe <axboe@...e.de>, Andrew Morton <akpm@...l.org>
Subject: [patch] x86, fix rwsem build bug on CONFIG_M386=y


* Adrian Bunk <bunk@...sta.de> wrote:

> This email lists some known regressions in 2.6.19-rc1 compared to 
> 2.6.18.

thanks Adrian - this list is extremely useful in my opinion! Please keep 
up the good work.

> Subject    : CONFIG_M386=y rwsem compile error
> References : http://lkml.org/lkml/2006/10/3/240
> Submitter  : Klaus Knopper <knopper@...pper.net>
> Guilty     : Andi Kleen <ak@...e.de>
>              commit add659bf8aa92f8b3f01a8c0220557c959507fb1
> Status     : unknown

find the fix below.

-------------------->
Subject: [patch] x86, fix rwsem build bug on CONFIG_M386=y
From: Ingo Molnar <mingo@...e.hu>

CONFIG_M386 turns on spinlock-based generic rwsems - which surprises the 
semaphore.S rwsem stubs. Tested both with and without CONFIG_M386.

Reported-by: Klaus Knopper <knopper@...pper.net>
Triaged-by: Adrian Bunk <bunk@...sta.de>

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/i386/lib/semaphore.S |    3 +++
 1 file changed, 3 insertions(+)

Index: linux/arch/i386/lib/semaphore.S
===================================================================
--- linux.orig/arch/i386/lib/semaphore.S
+++ linux/arch/i386/lib/semaphore.S
@@ -152,6 +152,8 @@ ENTRY(__read_lock_failed)
 
 #endif
 
+#ifdef CONFIG_RWSEM_XCHGADD_ALGORITHM
+
 /* Fix up special calling conventions */
 ENTRY(call_rwsem_down_read_failed)
 	CFI_STARTPROC
@@ -214,3 +216,4 @@ ENTRY(call_rwsem_downgrade_wake)
 	CFI_ENDPROC
 	END(call_rwsem_downgrade_wake)
 
+#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/