linux-kernel - Re: [PATCH] libata: Don't believe bogus claims in the older PIO mode register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4524E49B.2060101@pobox.com>
Date:	Thu, 05 Oct 2006 06:55:23 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata: Don't believe bogus claims in the older PIO mode
 register

Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@...hat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm2/drivers/ata/libata-core.c linux-2.6.18-mm2/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.18-mm2/drivers/ata/libata-core.c	2006-09-28 14:33:46.000000000 +0100
> +++ linux-2.6.18-mm2/drivers/ata/libata-core.c	2006-09-29 17:33:53.000000000 +0100
> @@ -870,7 +870,11 @@
>  		 * the PIO timing number for the maximum. Turn it into
>  		 * a mask.
>  		 */
> -		pio_mask = (2 << (id[ATA_ID_OLD_PIO_MODES] & 0xFF)) - 1 ;
> +		u8 mode = id[ATA_ID_OLD_PIO_MODES] & 0xFF;
> +		if( mode < 5)	/* Valid PIO range */
> +                	pio_mask = (2 << mode) - 1 ;
> +		else
> +			pio_mask = 1;

applied to #upstream-fixes, after fixing up stuff like "if( "


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/