linux-kernel - Re: [PATCH] Use linux/io.h instead of asm/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061005172611.GB2563@parisc-linux.org>
Date:	Thu, 5 Oct 2006 11:26:11 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Linus Torvalds <torvalds@...l.org>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use linux/io.h instead of asm/io.h

On Thu, Oct 05, 2006 at 01:19:42PM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >In preparation for moving check_signature, change these users from
> >asm/io.h to linux/io.h
> 
> The vast majority of drivers include asm/io.h.

Yes.  linux/io.h was only created recently.  It's proper style to
include linux/foo.h when both linux/foo.h and asm/foo.h exist [1]
This is just a transition which hasn't been completed yet (indeed, has
barely begun).

> Wouldn't it be better to move check_signature to 
> include/asm-generic/io.h, and include that where needed?

I really don't think that proliferating header files unnecessarily is a
good idea.

[1] Except, of course, <linux/irq.h>, but I thought rmk was going to fix
that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/