[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200610051732.44669.ajwade@cpe001346162bf9-cm0011ae8cd564.cpe.net.cable.rogers.com>
Date: Thu, 5 Oct 2006 17:31:56 -0400
From: Andrew James Wade <andrew.j.wade@...il.com>
To: Andrew Morton <akpm@...l.org>
Cc: andrew.j.wade@...il.com, tim.c.chen@...ux.intel.com,
herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org,
leonid.i.ananiev@...el.com
Subject: Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
On Thursday 05 October 2006 04:36, Andrew Morton wrote:
> On Thu, 5 Oct 2006 04:13:07 -0400
> Andrew James Wade <andrew.j.wade@...il.com> wrote:
>
> > (...)
>
>
> That all looks OK (by sheer luck).
>
> Well. What's the cache line size on that machine? Every exit() will cause
> a down_read() on task_exit_notifier's lock which might affect things. And
> I think you snipped the above list a bit short (depending on that line
> size).
>
>
> But still, we know that moving those things into __read_mostly didn't fix
> it, yes?
No. To my knowledge Tim Chen hasn't tried __read_mostly, and I have not
attempted to replicate the test case. (I only have a uniprocessor
machine.) Core 2 machines have a cache line size of 64 bytes, but Tim
Chen is likely using a different kernel/.config than I am so my objdump
isn't definitive.
Tim, perhaps you can try the __read_mostly marking as Andrew suggests?
signed-off-by: Andrew Wade <andrew.j.wade@...il.com>
upN a/include/asm-generic/bug.h b/include/asm-generic/bug.h
--- a/include/asm-generic/bug.h 2006-10-05 16:16:37.000000000 -0400
+++ b/include/asm-generic/bug.h 2006-10-05 16:33:08.000000000 -0400
@@ -42,7 +42,7 @@
#endif
#define WARN_ON_ONCE(condition) ({ \
- static int __warn_once = 1; \
+ static int __warn_once __read_mostly = 1; \
typeof(condition) __ret_warn_once = (condition);\
\
if (likely(__warn_once)) \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists