linux-kernel - Re: [PATCH -fix] swsusp: Make userland suspend work on SMP again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061005164036.06237b30.akpm@osdl.org>
Date:	Thu, 5 Oct 2006 16:40:36 -0700
From:	Andrew Morton <akpm@...l.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	LKML <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH -fix] swsusp: Make userland suspend work on SMP again

On Wed, 4 Oct 2006 22:26:42 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:

> Unfortunately one of the recent changes in swsusp has broken the userland
> suspend on SMP.  Fix it.
> 

Which patch does this fix?

> ---
> ---
>  kernel/power/user.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.18-mm3/kernel/power/user.c

I'll assume from this that your patch is applicable to -mm and that mainline
doesn't have this bug.

I'll further assume that it's swsusp-add-ioctl-for-swap-files-support.patch
which added the bug.

> ===================================================================
> --- linux-2.6.18-mm3.orig/kernel/power/user.c
> +++ linux-2.6.18-mm3/kernel/power/user.c
> @@ -149,10 +149,10 @@ static int snapshot_ioctl(struct inode *
>  			error = freeze_processes();
>  			if (error) {
>  				thaw_processes();
> +				enable_nonboot_cpus();
>  				error = -EBUSY;
>  			}
>  		}
> -		enable_nonboot_cpus();
>  		up(&pm_sem);
>  		if (!error)
>  			data->frozen = 1;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/