linux-kernel - Re: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1160143406.1607.80.camel@localhost.localdomain>
Date:	Fri, 06 Oct 2006 15:03:25 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Amol Lad <amol@...ismonetworks.com>
Cc:	linux kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 4/5] ioremap balanced with iounmap for
	drivers/char/rio/rio_linux.c

Ar Gwe, 2006-10-06 am 16:51 +0530, ysgrifennodd Amol Lad:
> > > +
> > > +		if (hp->Caddr)
> > > +			iounmap(hp->Caddr);
> > >  	}
> > 
> > I don't think this is sufficient because it may be unmapped earlier on
> > error but hp->Caddr is not then cleared .
> 
> Is this fine ?
> 
> Signed-off-by: Amol Lad <amol@...ismonetworks.com>

Acked-by: Alan Cox <alan@...hat.com>

Thanks

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/