linux-kernel - Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000610060921q493a3f58n45285e6dcc037156@mail.gmail.com>
Date:	Fri, 6 Oct 2006 12:21:27 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Linus Torvalds" <torvalds@...l.org>
Cc:	"Jeff Garzik" <jeff@...zik.org>,
	"David Howells" <dhowells@...hat.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	"Ingo Molnar" <mingo@...e.hu>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Andrew Morton" <akpm@...l.org>,
	"Thomas Gleixner" <tglx@...utronix.de>, "Greg KH" <greg@...ah.com>,
	"David Brownell" <david-b@...bell.net>,
	"Alan Stern" <stern@...land.harvard.edu>
Subject: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers

On 10/6/06, Linus Torvalds <torvalds@...l.org> wrote:

> In contrast, the irq argument itself is really no different from the
> cookie we pass in on registration - it's just passing it back to the
> driver that requested the thing. So unlike "regs", there's not really
> anything strange about it, and there's nothing really "wrong" with having
> it there.
>
> So I'm not at all as convinced about this one.

But drivers rarely care about exact IRQ that caused their interrupt
routines to be called. I looked at some of them and they normally use
it just to print warnings which is not critical (and data can still be
retrieved form elsewhere). And without it the only argument can very
nicely be passed via a register (if regparm is allowed).

Drivers that truly need to know IRQ can have it added to dev_id cookie
and use separate dev_ids.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/