linux-kernel - Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610060937120.3952@g5.osdl.org>
Date:	Fri, 6 Oct 2006 09:40:24 -0700 (PDT)
From:	Linus Torvalds <torvalds@...l.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:	Jeff Garzik <jeff@...zik.org>, David Howells <dhowells@...hat.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...l.org>,
	Thomas Gleixner <tglx@...utronix.de>, Greg KH <greg@...ah.com>,
	David Brownell <david-b@...bell.net>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than
 passing to IRQ handlers

On Fri, 6 Oct 2006, Dmitry Torokhov wrote:
> 
> But drivers rarely care about exact IRQ that caused their interrupt
> routines to be called.

Sure. But it's not a _cleanup_ as far as I can tell.

> Drivers that truly need to know IRQ can have it added to dev_id cookie
> and use separate dev_ids.

I'm not saying that what you describe is impossible. I'm just saying that 
it's pointless. 

What's wrong with passing in "irq"? It makes sense from a logical angle, 
and it's something you kind of expect if you think of irq's as "signals 
for the kernel" (which they almost literally used to be, why do you think 
it was called "SA_SHIRQ" etc?).

So there is absolutely nothing wrong with passing in irq from a conceptual 
or a practical angle, and some routines _do_ use it.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/