linux-kernel - Re: [PATCH] fix mesh compile errors after irq changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Oct 2006 21:09:07 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Olaf Hering <olaf@...fle.de>
cc:	Linus Torvalds <torvalds@...l.org>,
	David Howells <dhowells@...hat.com>,
	Andrew Morton <akpm@...l.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	linux-arch@...r.kernel.org, Dmitry Torokhov <dtor@...l.ru>,
	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH] fix mesh compile errors after irq changes

On Fri, 6 Oct 2006, Olaf Hering wrote:
> drivers/scsi/mesh.c:469: error: too many arguments to function 'mesh_interrupt'
> drivers/scsi/mesh.c:507: error: too many arguments to function 'mesh_interrupt'
> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>
> 
> ---
>  drivers/scsi/mesh.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/drivers/scsi/mesh.c
> ===================================================================
> --- linux-2.6.orig/drivers/scsi/mesh.c
> +++ linux-2.6/drivers/scsi/mesh.c
> @@ -466,7 +466,7 @@ static void mesh_start_cmd(struct mesh_s
>  				dlog(ms, "intr b4 arb, intr/exc/err/fc=%.8x",
>  				     MKWORD(mr->interrupt, mr->exception,
>  					    mr->error, mr->fifo_count));
> -				mesh_interrupt(0, (void *)ms, NULL);
> +				mesh_interrupt(0, (void *)ms);
                                                  ^^^^^^^^
>  				if (ms->phase != arbitrating)
>  					return;
>  			}
> @@ -504,7 +504,7 @@ static void mesh_start_cmd(struct mesh_s
>  		dlog(ms, "intr after disresel, intr/exc/err/fc=%.8x",
>  		     MKWORD(mr->interrupt, mr->exception,
>  			    mr->error, mr->fifo_count));
> -		mesh_interrupt(0, (void *)ms, NULL);
> +		mesh_interrupt(0, (void *)ms);
                                  ^^^^^^^^
These casts are superfluous, right?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/