linux-kernel - Re: [PATCH 5/5] fdtable: Extensive fs/file.c cleanups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Oct 2006 13:22:58 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Vadim Lobanov <vlobanov@...akeasy.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] fdtable: Extensive fs/file.c cleanups.

On Thu, 5 Oct 2006 21:52:28 -0700
Vadim Lobanov <vlobanov@...akeasy.net> wrote:

> As long as the previous patch replaces the guts of fs/file.c, it makes sense
> to tidy up all the code within. This work includes:
> 	code simplification via refactoring,
> 	elimination of unnecessary code paths,
> 	extensive commenting throughout the entire file, and
> 	other minor cleanups and consistency tweaks.
> This patch does not contain any functional modifications.
> 
> This is the last patch in the series. All the code should now be sparkly
> clean.

This (wordwrapped) patch should have been the first in the series, not the
last.  Having the substantive changes come after the cleanups makes
subsequent problem diagnosis simpler, means we have less code to revert if
it goes bad, etc.

So I'll drop this one.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/