lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200610061608.29085.vlobanov@speakeasy.net>
Date:	Fri, 6 Oct 2006 16:08:29 -0700
From:	Vadim Lobanov <vlobanov@...akeasy.net>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] fdtable: Extensive fs/file.c cleanups.

On Friday 06 October 2006 15:42, Andrew Morton wrote:
> On Fri, 6 Oct 2006 14:38:07 -0700
>
> Vadim Lobanov <vlobanov@...akeasy.net> wrote:
> > This patch still has a lot of useful (and I'd argue necessary) fixes for
> > incorrect comments and confusing code ordering. It's especially nice for
> > those who might try to understand what's going on inside fs/file.c, so
> > seems a shame to drop it. I could...
> > 	... hold on to it until the other fdtable changes hit mainline.
> > 		or
> > 	... redo this one with just the bare essentials.
> > 		or
> > 	... drop it completely.
>
>                 or
>         ... redo the patches so this one comes first.
>
> Which sounds like a hassle.  If it's too much hassle, your option 1 sounds
> OK.

I'll hold on to it for now, then. It's probably best, so there's less 
code-churn, and the patches will hopefully get more technical reviews and 
testing.

In the future, I'll make sure to send cleanups first in the series. Thanks for 
the feedback. :)

-- Vadim Lobanov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ