[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061007182301.GA25352@filer.fsl.cs.sunysb.edu>
Date: Sat, 7 Oct 2006 14:23:01 -0400
From: Josef Sipek <jsipek@....cs.sunysb.edu>
To: Daniel Walker <dwalker@...sta.com>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
torvalds@...l.org, akpm@...l.org, hch@...radead.org,
viro@....linux.org.uk
Subject: Re: [PATCH 2 of 23] lookup_one_len_nd - lookup_one_len with nameidata argument
On Sat, Oct 07, 2006 at 10:03:53AM -0700, Daniel Walker wrote:
> On Sat, 2006-10-07 at 01:07 -0400, Josef Jeff Sipek wrote:
>
> > -struct dentry * lookup_one_len(const char * name, struct dentry * base, int len)
> > +struct dentry * lookup_one_len_nd(const char *name, struct dentry * base, int len, struct nameidata *nd)
>
> > -extern struct dentry * lookup_one_len(const char *, struct dentry *, int);
> > +extern struct dentry * lookup_one_len_nd(const char *, struct dentry *, int, struct nameidata *);
> > +
> > +/* SMP-safe */
> > +static inline struct dentry *lookup_one_len(const char *name, struct dentry *dir, int len)
>
>
> These lines are all too long . Should max out at 80 characters.
A large portion of that file has lines >80 chars. I just kept it consistent.
Josef 'Jeff' Sipek.
--
Computer Science is no more about computers than astronomy is about
telescopes.
- Edsger Dijkstra
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists