linux-kernel - Re: [2.6 patch] HT_IRQ must depend on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1odsnufm8.fsf@ebiederm.dsl.xmission.com>
Date:	Sun, 08 Oct 2006 07:00:31 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Adrian Bunk <bunk@...sta.de>
Cc:	linux-kernel@...r.kernel.org, Jesper Juhl <jesper.juhl@...il.com>,
	gregkh@...e.de, linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: [2.6 patch] HT_IRQ must depend on PCI

Adrian Bunk <bunk@...sta.de> writes:

Looks good to me.

Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

> CONFIG_PCI=n, CONFIG_HT_IRQ=y results in the following compile error:
>
> <--  snip  -->
>
> ...
>   LD      vmlinux
> arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
> summit.c:(.text+0x53): undefined reference to `apicid_2_node'
> arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
> (.text+0xcf79): undefined reference to `write_ht_irq_low'
> arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
> (.text+0xcf85): undefined reference to `write_ht_irq_high'
> arch/i386/kernel/built-in.o: In function `k7nops':
> alternative.c:(.data+0x1358): undefined reference to `mask_ht_irq'
> alternative.c:(.data+0x1360): undefined reference to `unmask_ht_irq'
> make[1]: *** [vmlinux] Error 1
>
> <--  snip  -->
>
> Bug report by Jesper Juhl.
>
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
>
> --- linux-2.6/drivers/pci/Kconfig.old	2006-10-08 05:55:51.000000000 +0200
> +++ linux-2.6/drivers/pci/Kconfig	2006-10-08 05:56:14.000000000 +0200
> @@ -55,7 +55,7 @@
>  config HT_IRQ
>  	bool "Interrupts on hypertransport devices"
>  	default y
> -	depends on X86_LOCAL_APIC && X86_IO_APIC
> +	depends on PCI && X86_LOCAL_APIC && X86_IO_APIC
>  	help
>  	   This allows native hypertransport devices to use interrupts.
>  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/