linux-kernel - Re: [2.6.19 patch] ATA must depend on BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <452A49D5.4060904@s5r6.in-berlin.de>
Date:	Mon, 09 Oct 2006 15:08:37 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Adrian Bunk <bunk@...sta.de>
CC:	jgarzik@...ox.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
	Jesper Juhl <jesper.juhl@...il.com>
Subject: Re: [2.6.19 patch] ATA must depend on BLOCK

Adrian Bunk wrote:
> This patch fixes the following compile error with CONFIG_ATA=y, 
> CONFIG_BLOCK=n:
[...]
>  config ATA
>  	tristate "ATA device support"
> +	depends on BLOCK
>  	depends on !(M32R || M68K) || BROKEN
>  	depends on !SUN4 || BROKEN
>  	select SCSI

The Kconfig isn't broken but the tool which generated the .config.

"config ATA\ select SCSI" implies a dependency of ATA on SCSI. SCSI
depends on BLOCK.

Therefore "select SCSI" && "config SCSI\ depends on BLOCK" implies
either "config ATA\ select BLOCK" or "config ATA\ depends on BLOCK".

{Ignore all what I said if ATA code directly uses the block API. Usages
of the block API to manipulate SCSI data structures, particularly the
request queue, does not necessarily count as independent usage of the
block API though.}
-- 
Stefan Richter
-=====-=-==- =-=- -=---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/