linux-kernel - Re: [PATCH 2.6.19-git] Fix error handling in create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061009192201.140eae35@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 9 Oct 2006 19:22:01 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Luca Tettamanti <kronos.it@...il.com>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19-git] Fix error handling in create_files()

On Mon, 9 Oct 2006 19:03:57 +0200,
Luca Tettamanti <kronos.it@...il.com> wrote:

> While we are at it: is it safe to always call sysfs_remove_group even if
> the preceding sysfs_create_group failed?

No, it will oops in remove_dir(). (See also the recent discussion in
"drivers/base: error handling fixes" - drivers/base/topology.c has
problems in that area as well...)

-- 
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@...ibm.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/