linux-kernel - Re: drivers/char/specialix.c: broken baud conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061009063744.GB2877@bitwizard.nl>
Date:	Mon, 9 Oct 2006 08:37:45 +0200
From:	Rogier Wolff <R.E.Wolff@...Wizard.nl>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org,
	R.E.Wolff@...Wizard.nl
Subject: Re: drivers/char/specialix.c: broken baud conversion

On Mon, Oct 09, 2006 at 12:18:19AM +0200, Adrian Bunk wrote:
> +       if (baud == 38400) {
>                 if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_HI)
>                         baud ++;
>                 if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_VHI)
>                         baud += 2;
>         }
> 
> Increasing the index for baud_table[] by 1 or 2 is quite different from 
> increasing baud by 1 or 2.

In that range, 
	baud <<= 1; 
and
	baud <<= 2; 

should work. 

	Roger. 

-- 
** R.E.Wolff@...Wizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. 
Does it sit on the couch all day? Is it unemployed? Please be specific! 
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/