linux-kernel - Re: [PATCH] SCSI sd: fix module init/exit error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061010093706.GJ395@infradead.org>
Date:	Tue, 10 Oct 2006 10:37:06 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-scsi@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] SCSI sd: fix module init/exit error handling

On Wed, Oct 04, 2006 at 05:32:54AM -0400, Jeff Garzik wrote:
> 
> - Properly handle and unwind errors in init_sd().  Fixes leaks on error,
>   if class_register() or scsi_register_driver() failed.
> 
> - Ensure that exit_sd() execution order is the perfect inverse of
>   initialization order.
> 
> FIXME:  If some-but-not-all register_blkdev() calls fail, we wind up
> calling unregister_blkdev() for block devices we did not register.
> This was a pre-existing bug.
> 
> Signed-off-by: Jeff Garzik <jeff@...zik.org>

Ok.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/