[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 10 Oct 2006 08:27:06 -0400
From: Trond Myklebust <Trond.Myklebust@...app.com>
To: Steve Dickson <SteveD@...hat.com>
Cc: David Howells <dhowells@...hat.com>, Andrew Morton <akpm@...l.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] VM: Fix the gfp_mask in invalidate_complete_page2
On Tue, 2006-10-10 at 08:18 -0400, Steve Dickson wrote:
>
> Trond Myklebust wrote:
> >
> > No. Invalidatepage does precisely the wrong thing: it invalidates dirty
> > data instead of committing it to disk. If you need to have the data
> > invalidated, then you should call truncate_inode_pages().
> Just curious... would it make sense to call truncate_inode_pages()
> to purge the the readdir cache? Meaning, in nfs_revalidate_mapping()
> truncate_inode_pages() would be called for S_ISDIR inodes?
Why? If, as in the case of an NFS directory, there are no dirty pages
then the two are supposed to be 100% equivalent.
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists