linux-kernel - Re: Dropping NETIF_F_SG since no checksum feature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061010144330.GA28175@mellanox.co.il>
Date:	Tue, 10 Oct 2006 16:43:30 +0200
From:	"Michael S. Tsirkin" <mst@...lanox.co.il>
To:	Stephen Hemminger <shemminger@...l.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, openib-general@...nib.org,
	Roland Dreier <rolandd@...co.com>
Subject: Re: Dropping NETIF_F_SG since no checksum feature.

Quoting r. Stephen Hemminger <shemminger@...l.org>:
> Subject: Re: Dropping NETIF_F_SG since no checksum feature.
> 
> On Mon, 9 Oct 2006 19:47:05 +0200
> "Michael S. Tsirkin" <mst@...lanox.co.il> wrote:
> 
> > Hi!
> > I'm trying to build a network device driver supporting a very large MTU (around 64K)
> > on top of an infiniband connection, and I've hit a couple of issues I'd
> > appreciate some feedback on:
> > 
> > 1. On the send side,
> >    I've set NETIF_F_SG, but hardware does not support checksum offloading,
> >    and I see "dropping NETIF_F_SG since no checksum feature" warning,
> >    and I seem to be getting large packets all in one chunk.
> >    The reason I've set NETIF_F_SG, is because I'm concerned that under real life
> >    stress Linux won't be able to allocate 64K of continuous memory.
> > 
> >    Is this concern of mine valid? I saw in-tree drivers allocating at least 8K.
> >    What's the best way to enable S/G on send side?
> >    Is checksum offloading really required for S/G?
> 
> Yes, in the current implementation, Linux needs checksum offload. But there
> is no reason, your driver can't compute the checksum in software.

Are there drivers that do this already? Couldn't find any such beast ...

I'm worried whether an extra pass over data won't eat up all of
the performance gains I get from the large MTU ...

> >    What are the helpers legal for fragmented skb?

BTW, I found skb_put_frags in sky2 which seems generic enough - I even wander
why isn't this in net/core.

Thanks!

-- 
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/