linux-kernel - Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Oct 2006 09:14:01 -0700
From:	Auke Kok <auke-jan.h.kok@...el.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
CC:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	trivial@...nel.org
Subject: Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.

Robert P. J. Day wrote:
> Delete the minimally-useful IXGB_DBG() macro and call pr_debug()
> directly from the main routine.
> 
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> ---
> diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> index 50ffe90..fb9fde5 100644
> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
> @@ -77,12 +77,6 @@ #include "ixgb_hw.h"
>  #include "ixgb_ee.h"
>  #include "ixgb_ids.h"
> 
> -#ifdef _DEBUG_DRIVER_
> -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> -#else
> -#define IXGB_DBG(args...)
> -#endif
> -
>  #define PFX "ixgb: "
>  #define DPRINTK(nlevel, klevel, fmt, args...) \
>  	(void)((NETIF_MSG_##nlevel & adapter->msg_enable) && \
> diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> index e09f575..eada685 100644
> --- a/drivers/net/ixgb/ixgb_main.c
> +++ b/drivers/net/ixgb/ixgb_main.c
> @@ -1948,7 +1948,7 @@ #endif
> 
>  			/* All receives must fit into a single buffer */
> 
> -			IXGB_DBG("Receive packet consumed multiple buffers "
> +			pr_debug("ixgb: Receive packet consumed multiple buffers "
>  					 "length<%x>\n", length);
> 
>  			dev_kfree_skb_irq(skb);
> 
> --
> 
>   all right ... what did i mess up *this* time?  :-)  it's good
> practice.  that's my story and i'm sticking to it.

We should really use dev_dbg() instead, as it retains the 'ethX:' annotation afaics.

I'll have to see what looks best and also handle e100 and e1000.

Thanks,

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/