[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 10 Oct 2006 12:14:18 -0700
From: Greg KH <greg@...ah.com>
To: Hugh Dickins <hugh@...itas.com>
Cc: Greg KH <gregkh@...e.de>, akpm@...l.org,
Nick Piggin <nickpiggin@...oo.com.au>,
Randy Dunlap <rdunlap@...otime.net>,
"Theodore Ts'o" <tytso@....edu>,
Zwane Mwaikambo <zwane@....linux.org.uk>,
Justin Forbes <jmforbes@...uxtx.org>,
linux-kernel@...r.kernel.org,
Chris Wedgwood <reviews@...cw.f00f.org>, torvalds@...l.org,
Michael Krufky <mkrufky@...uxtv.org>,
Dave Jones <davej@...hat.com>,
Chuck Wolber <chuckw@...ntumlinux.com>, stable@...nel.org,
alan@...rguk.ukuu.org.uk
Subject: Re: [stable] [patch 07/19] invalidate_complete_page() race fix
On Tue, Oct 10, 2006 at 07:12:54PM +0100, Hugh Dickins wrote:
> On Tue, 10 Oct 2006, Greg KH wrote:
>
> > -stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> > From: Andrew Morton <akpm@...l.org>
> >
> > If a CPU faults this page into pagetables after invalidate_mapping_pages()
> > checked page_mapped(), invalidate_complete_page() will still proceed to remove
> > the page from pagecache. This leaves the page-faulting process with a
> > detached page. If it was MAP_SHARED then file data loss will ensue.
> >
> > Fix that up by checking the page's refcount after taking tree_lock.
>
> I may have lost the plot, but I think this patch has already proved
> to cause problems for NFS in 2.6.18: not good to put it into 2.6.17
> stable while it's awaiting refinement for 2.6.18 stable.
Ok, I've dropped it now.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists