linux-kernel - Re: driver,platform,firmware,system, data data data ....

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Oct 2006 07:48:07 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
CC:	Greg KH <greg@...ah.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: driver,platform,firmware,system, data data data ....

Benjamin Herrenschmidt wrote:

[ device->platform_data ]

> So except for the size of the patch and boredom of going through all
> of them fixing them, do you see any reason why this later one
> shouldn't be moved out to platform_driver ? (I haven't actually
> checked at all the occurences in the tree though).

You'll find it being used in drivers/base/isa.c for one. I only used it 
there because it was available and made for slightly nicer code though. 
If platform_data is going away (and assuming you wouldn't want similar 
abuse of your new system_data) it wouldn't be a problem to move the 
driver pointer to the private struct isa_dev as in the attached.

Rene.

View attachment "isa_bus_platform_data.diff" of type "text/plain" (3333 bytes)