linux-kernel - Re: [PATCH] arm: it's OK to pass pointer to volatile as iounmap() argument...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061009193534.GA4358@ucw.cz>
Date:	Mon, 9 Oct 2006 19:35:35 +0000
From:	Pavel Machek <pavel@....cz>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Linus Torvalds <torvalds@...l.org>, rmk@....linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: it's OK to pass pointer to volatile as iounmap() argument...

Hi!

> --- a/arch/arm/mm/ioremap.c
> +++ b/arch/arm/mm/ioremap.c
> @@ -361,14 +361,14 @@ __ioremap(unsigned long phys_addr, size_
>  }
>  EXPORT_SYMBOL(__ioremap);
>  
> -void __iounmap(void __iomem *addr)
> +void __iounmap(volatile void __iomem *addr)

Who is crazy enough to pass volatile pointers here? I guess they should be
fixed, instead.

							Pavel
-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/