linux-kernel - Re: Potential fix for fdtable badness.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1160570527.30819.1.camel@kleikamp.austin.ibm.com>
Date:	Wed, 11 Oct 2006 07:42:07 -0500
From:	Dave Kleikamp <shaggy@...tin.ibm.com>
To:	Vadim Lobanov <vlobanov@...akeasy.net>
Cc:	Olof Johansson <olof@...om.net>,
	Linas Vepstas <linas@...tin.ibm.com>,
	Bryce Harrington <bryce@...l.org>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: Potential fix for fdtable badness.

On Tue, 2006-10-10 at 19:08 -0700, Vadim Lobanov wrote:
> All,
> 
> Sorry about the recent fdtable badness that you all encountered. I'm working
> on getting a fix out there.
> 
> Dave, Olof, Linas, Bryce,
> 
> Could you please test the patch at the bottom of the email to see if it makes
> your computers happy again, if you have the time and inclination to do so?

The patch works for me.  Thanks!

Shaggy

> Andrew,
> 
> Would you prefer me to resend a fixed patch #4, or a new fix (#5) on top of
> what's in your tree?
> 
> diff -Npru old/fs/file.c new/fs/file.c
> --- old/fs/file.c	2006-10-10 18:58:21.000000000 -0700
> +++ new/fs/file.c	2006-10-10 19:01:03.000000000 -0700
> @@ -164,9 +164,8 @@ static struct fdtable * alloc_fdtable(un
>  	 * the fdarray into page-sized chunks: starting at a quarter of a page,
>  	 * and growing in powers of two from there on.
>  	 */
> -	nr++;
>  	nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
> -	nr = roundup_pow_of_two(nr);
> +	nr = roundup_pow_of_two(nr + 1);
>  	nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
>  	if (nr > NR_OPEN)
>  		nr = NR_OPEN;
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/