linux-kernel - Re: [PATCH 2.6.19-rc1-mm1] Export jiffies_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061011111739.09c25a8e.akpm@osdl.org>
Date:	Wed, 11 Oct 2006 11:17:39 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, john stultz <johnstul@...ibm.com>
Subject: Re: [PATCH 2.6.19-rc1-mm1] Export jiffies_to_timespec()

On Wed, 11 Oct 2006 17:16:28 +0100
Christoph Hellwig <hch@...radead.org> wrote:

> On Tue, Oct 10, 2006 at 05:36:54PM -0700, Jeremy Fitzhardinge wrote:
> > Export jiffies_to_timespec; previously modules used the inlined header 
> > version.
> 
> NACK, drivers shouldn know about these timekeeping details and no
> in-tree driver uses it (fortunately)

Disagree.

a) `jiffies' and `timepsec' are hardly "details".  They are basic
   kernel-wide concepts.  timespecs are even known to userspace.  Exporting
   a helper function which converts from one to the other is perfectly
   reasonable.

b) jiffies_to_timespec() was previously available to modules.  We
   changed that without notice and we changed it *by accident*.  There was
   no intention to withdraw jiffies_to_timespec() from the
   available-to-modules API.

If we really wanted to withdraw jiffies_to_timespec() then we'd mark it
__deprecated_for_modules for a while, then withdraw it.  But there's no
earthly reason why we'd want to withdraw it: the export makes sense.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/