linux-kernel - RE: Hugepage regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000401c6ecdf$8ea49250$cb34030a@amr.corp.intel.com>
Date:	Tue, 10 Oct 2006 19:47:04 -0700
From:	"Chen, Kenneth W" <kenneth.w.chen@...el.com>
To:	"'David Gibson'" <david@...son.dropbear.id.au>
Cc:	"'Hugh Dickins'" <hugh@...itas.com>,
	"Andrew Morton" <akpm@...l.org>, <linux-kernel@...r.kernel.org>
Subject: RE: Hugepage regression

David Gibson wrote on Tuesday, October 10, 2006 6:18 PM
> Can I suggest that you put a big comment on the linked list
> declaration itself saying that you're relying on serialization here.
> Otherwise I'm worried someone will try to de-serialize it again, and
> break it without realizing.  Given the number of people who failed to
> spot the problem with the patch the first time around..


I'm not very good at writing comments, how about the following?

Signed-off-by: Ken Chen <kenneth.w.chen@...el.com>

--- linus-2.6/mm/hugetlb.c.orig	2006-10-10 19:32:36.000000000 -0700
+++ linus-2.6/mm/hugetlb.c	2006-10-10 19:41:18.000000000 -0700
@@ -365,6 +365,11 @@ void __unmap_hugepage_range(struct vm_ar
 	pte_t pte;
 	struct page *page;
 	struct page *tmp;
+	/*
+	 * A page gathering list, protected by per file i_mmap_lock. The
+	 * lock is used to avoid list corruption from multiple unmapping
+	 * of the same page since we are using page->lru.
+	 */
 	LIST_HEAD(page_list);
 
 	WARN_ON(!is_vm_hugetlb_page(vma));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/