linux-kernel - [PATCH] take #2 report_lost_ticks boot parameter should be default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 12 Oct 2006 03:18:18 +0100
From:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
To:	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH] take #2 report_lost_ticks boot parameter should be default

Hi,

Forgot sign-off just in case :)

I tried the 2.6.18-mm3 and I tried boot up with acpi=noirq (which is the
same of pci=noacpi), and boots fine without any warning.
And it was a nightmare on stress testings of this two days. At begging I
don't understand why, but after a while I remember try report_lost_ticks
and nightmare ends. The boot parameter reports lost ticket everywhere,
because I (still) need boot up with "notsc".
I believe that it not just my computer that suffer this problem and with
report_lost_ticks by default, we understand quickly that we need boot
with "notsc" or something else. For computer don't crash on a little
stress. Like play a avi movie with mplyer and copy over Ethernet some
others files.
 
Something like this : 

Signed-off-by: Sergio Monteiro Basto <sergio@...giomb.no-ip.org>

 time.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff ./x86_64/kernel/time.c.orig ./x86_64/kernel/time.c -up
--- ./x86_64/kernel/time.c.orig 2006-10-12 02:50:41.000000000 +0100
+++ ./x86_64/kernel/time.c      2006-10-12 02:54:52.000000000 +0100
@@ -71,7 +71,7 @@ static unsigned long hpet_period;                     /* f
 unsigned long hpet_tick;                               /* HPET clocks / interrupt */
 int hpet_use_timer;                            /* Use counter of hpet for time keeping, otherwise PIT */
 unsigned long vxtime_hz = PIT_TICK_RATE;
-int report_lost_ticks;                         /* command line option */
+int noreport_lost_ticks;                               /* command line option */
 unsigned long long monotonic_base;

 struct vxtime_data __vxtime __section_vxtime;  /* for vsyscalls */
@@ -316,7 +316,7 @@ static noinline void handle_lost_ticks(i
 {
        static long lost_count;
        static int warned;
-       if (report_lost_ticks) {
+       if (!noreport_lost_ticks) {
                printk(KERN_WARNING "time.c: Lost %d timer tick(s)! ", lost);
                print_symbol("rip %s)\n", regs->rip);
        }
@@ -885,7 +885,7 @@ void __init stop_timer_interrupt(void)

 int __init time_setup(char *str)
 {
-       report_lost_ticks = 1;
+       noreport_lost_ticks = 1;
        return 1;
 }

@@ -1004,7 +1004,7 @@ __init static char *time_init_gtod(void)
        return timetype;
 }

-__setup("report_lost_ticks", time_setup);
+__setup("noreport_lost_ticks", time_setup);

 static long clock_cmos_diff;
 static unsigned long sleep_start;

Thanks,
-- 
Sérgio M.B.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (2166 bytes)