linux-kernel - Re: Fwd: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <452DD8B2.9040007@drzeus.cx>
Date:	Thu, 12 Oct 2006 07:54:58 +0200
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	Alex Dubov <oakad@...oo.com>, Jeff Garzik <jgarzik@...ox.com>,
	Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Fwd: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume

Doesn't Jeff love me anymore? :(

Alex Dubov wrote:
> --- Jeff Garzik <jeff@...zik.org> wrote:
>
>   
>> Date: Wed, 11 Oct 2006 17:48:09 -0400
>> From: Jeff Garzik <jeff@...zik.org>
>> To: oakad@...oo.com, Andrew Morton <akpm@...l.org>,
>> 	LKML <linux-kernel@...r.kernel.org>
>> Subject: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
>>
>>
>> Since pci_enable_device() is one of the first things called in the
>> resume step, take the minimalist approach and return immediately, if
>> pci_enable_device() fails during resume.
>>
>> Also, in sdhci:  don't check for impossible condition (chip==NULL)
>>
>> Signed-off-by: Jeff Garzik <jeff@...zik.org>
>>
>>     

I'm just being cautious. "This can't happen" is usually the last thing
you here before the end. ;)

Signed-off-by: Pierre Ossman <drzeus@...eus.cx>

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
  OLPC, developer                     http://www.laptop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/