linux-kernel - Re: [PATCH] lockdep: annotate i386 apm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061012002906.dd29c376.akpm@osdl.org>
Date:	Thu, 12 Oct 2006 00:29:06 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, sfr@...b.auug.org.au,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] lockdep: annotate i386 apm

On Thu, 12 Oct 2006 08:50:50 +0200
Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> Was my original _that_ hard to read?

The macro was bad enough.  Then you want an added another one and made it
reference a caller's local variable.  Another dummy-shaped dent in my wall.

I'd appreciate a fixed-up patch which changes the code's niceness in a
positive direction please - I'm obviously not cut out to work on apm.c.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/