linux-kernel - Re: [PATCH] fix fm801_gp_probe() ignoring return value from pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Oct 2006 22:36:47 -0400
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	Jiri Kosina <jikos@...os.cz>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	linux-input@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH] fix fm801_gp_probe() ignoring return value from pci_enable_device()

On Thursday 12 October 2006 19:27, Jiri Kosina wrote:
> [PATCH] fix fm801_gp_probe() ignoring return value from pci_enable_device()
> 
> Fix fm801_gp_probe() not handling pci_enable_device() return value 
> correctly.
> 
> Signed-off-by: Jiri Kosina <jikos@...os.cz>
> 
> --- 
> 
>  drivers/input/gameport/fm801-gp.c |   23 ++++++++++++++++-------
>  1 files changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/input/gameport/fm801-gp.c b/drivers/input/gameport/fm801-gp.c
> index 90de5af..5ac9e15 100644
> --- a/drivers/input/gameport/fm801-gp.c
> +++ b/drivers/input/gameport/fm801-gp.c
> @@ -82,17 +82,22 @@ static int __devinit fm801_gp_probe(stru
>  {
>  	struct fm801_gp *gp;
>  	struct gameport *port;
> +	int err;
>  
>  	gp = kzalloc(sizeof(struct fm801_gp), GFP_KERNEL);
>  	port = gameport_allocate_port();
>  	if (!gp || !port) {
>  		printk(KERN_ERR "fm801-gp: Memory allocation failed\n");
> -		kfree(gp);
> -		gameport_free_port(port);
> -		return -ENOMEM;
> +		err = -ENOMEM;
> +		goto out_err;
>  	}
>  

Hi Jiri,

It looks like you left pci device enabled. Anyway, Jeff Garzik beat you
to it ;) I spplied his patch to my tree yesterday.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/