[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061013112821.55c00b03@dxpl.pdx.osdl.net>
Date: Fri, 13 Oct 2006 11:28:21 -0700
From: Stephen Hemminger <shemminger@...l.org>
To: Adrian Bunk <bunk@...sta.de>
Cc: Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
Stephane Eranian <eranian@....hp.com>, sam@...nborg.org
Subject: Re: [PATCH] rename net_random to random32
On Fri, 13 Oct 2006 20:19:22 +0200
Adrian Bunk <bunk@...sta.de> wrote:
> On Thu, Oct 12, 2006 at 10:26:38AM -0700, Stephen Hemminger wrote:
> >
> > Make net_random() more widely available by calling it random32
> >...
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -5,7 +5,7 @@ #
> > lib-y := ctype.o string.o vsprintf.o cmdline.o \
> > bust_spinlocks.o rbtree.o radix-tree.o dump_stack.o \
> > idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \
> > - sha1.o irq_regs.o carta_random32.o
> > + sha1.o irq_regs.o random32.o carta_random32.o
> >...
> > --- /dev/null
> > +++ b/lib/random32.c
> >...
> > +EXPORT_SYMBOL(random32);
> >...
> > +EXPORT_SYMBOL(srandom32);
> >...
>
> EXPORT_SYMBOL's in lib-y are latent bugs (IMHO kbuild should error
> on them):
>
> The problem is that if only modules use these functions, they will be
> omitted from the kernel image.
>
> cu
> Adrian
>
The main net code uses the code so it isn't really an issue in this case.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists