linux-kernel - Re: [linux-pm] Bug in PCI core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0610131657540.8377-100000@iolanthe.rowland.org>
Date:	Fri, 13 Oct 2006 16:59:45 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Matthew Wilcox <matthew@....cx>
cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, Adam Belay <abelay@....EDU>,
	Arjan van de Ven <arjan@...radead.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Greg KH <greg@...ah.com>, <linux-pci@...ey.karlin.mff.cuni.cz>,
	Linux-pm mailing list <linux-pm@...ts.osdl.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [linux-pm] Bug in PCI core

On Fri, 13 Oct 2006, Matthew Wilcox wrote:

> On Fri, Oct 13, 2006 at 01:57:48PM -0400, Alan Stern wrote:
> > Would it be okay for pci_block_user_cfg_access() to use its own cache, so 
> > it doesn't interfere with data previously cached by pci_save_state()?
> 
> My suggestion is just to require that the callers have previously called
> pci_save_state().  The PCI PM stack already has, and it's a one-line
> change to the IPR driver.

Okay.  Would you like to write a patch with that fix?  Be sure to add a 
comment explaining the need for a previous call to pci_save_state().

At least it will get things going for now, even if it isn't perfectly
correct in the long run.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/